Add async support to dfu-core #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to its name DfuSansIo actually contains an I/O object and triggers I/O operations. This in particular makes it impossible to create both sync and async implementation. Transform DfuSansIo and its actions to a pure SansIo strategy by returning the operation to execute rather then actually execute the operation direction.
Create a async io implementation (DfuAsyncIo) similar to the current sync implementation (DfuSync). This can be enabled by the "async feature".
|
Hello! Sorry for the long delay. I invite you to the organization :) Thank you so much for joining! You can of course help maintain all the projects of the org and add dfu-nusb to it |
cecton
approved these changes
Nov 4, 2024
|
@sjoerdsimons I let you merge and make a release so you get a hand of it? I'm using cargo-release but feel free to use whatever works and improve the process if you want to |
Sure i can do that; might need to wait till the weekend though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow implementation using both sync and async I/O; The async support is enabled with the "async" feature (assume "std"). Tested using dfu-libusb (no changes needed) and a new implementation using nusb (https://github.com/sjoerdsimons/dfu-nusb). dfu-nusb supports both sync and async support.
Fwiw, i'd be happy to host dfu-nusb in this organisation, but that's somewhat seperate from this PR :)